[PATCH] D18837: Permit memory operands in ins/outs instructions

[Ahmed Bougacha via llvm-commits]

ab added a subscriber: ab.
ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.

Gross, but LGTM.


================
Comment at: test/MC/X86/x86-32.s:603
@@ +602,3 @@
+// CHECK: outl	%eax, %dx
+
+out	%al, (%dx)
----------------
It's *really* minor, but the inconsistent newlines make me twitch: either separate the CHECKs from the instructions, or don't ;)

================
Comment at: test/MC/X86/x86-32.s:625
@@ +624,3 @@
+
+//PR15455
+// CHECK: outsw	(%esi), %dx
----------------
space

================
Comment at: test/MC/X86/x86-64.s:284
@@ -283,1 +283,3 @@
 
+//PR15455
+// CHECK: outsw	(%rsi), %dx
----------------
space

================
Comment at: test/MC/X86/x86-64.s:290
@@ +289,3 @@
+
+outs	(%rsi), (%dx) //permitted invalid memory form
+outsb	(%rsi), (%dx)
----------------
Comment in a separate line?


http://reviews.llvm.org/D18837