[PATCH] D21711: [yaml2obj] Remove --format option in favor of YAML tags

[Saleem Abdulrasool via llvm-commits]

On Fri, Jun 24, 2016 at 7:22 PM, Saleem Abdulrasool <compnerd at compnerd.org>
wrote:

> compnerd added a subscriber: compnerd.
> compnerd accepted this revision.
> compnerd added a reviewer: compnerd.
> compnerd added a comment.
> This revision is now accepted and ready to land.
>
> Nice!  I think it would be a good idea to add a few tests.  Basically,
> feed it a yaml document and ensure that the format detection happens
> correctly.
>

Just to add this for the record, this should also correct an instance of an
assert triggering in an Asserts built with the incorrect format being
selected.


> ================
> Comment at: tools/yaml2obj/yaml2macho.cpp:450
> @@ -449,3 +449,3 @@
>    }
>    if (auto Err = writeFatHeader(OS))
>      return Err;
> ----------------
> Not your fault, but its hard to see that the code here is switching
> between a fat macho or a sliced/lipo'ed/thin one.
>
>
> http://reviews.llvm.org/D21711
>
>
>
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160625/d8e8e200/attachment.html>