[PATCH] D21481: ELF/AMDGPU: Add support for GOT relocations

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with a stylistic change.


================
Comment at: ELF/Target.cpp:1434
@@ +1433,3 @@
+    fatal("do not know how to handle relocation " + Twine(Type));
+  // fall-through
+  case R_AMDGPU_REL32:
----------------
fatal does not return, so remove this comment. Also, please move `default:` at end of this switch to make the order of the cases the same as the above switch.


http://reviews.llvm.org/D21481