[PATCH] D21721: Object: Replace NewArchiveIterator with a simpler NewArchiveMember class. NFCI.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 20:14:36 PDT 2016


pcc created this revision.
pcc added a reviewer: rafael.
pcc added a subscriber: llvm-commits.

The NewArchiveIterator class has a problem: it requires too much context. Any
memory buffers added to the archive must be stored within an Archive::Member,
which must have an associated Archive. This makes it harder than necessary
to create new archive members (or new archives entirely) from scratch using
memory buffers.

This patch replaces NewArchiveIterator with a NewArchiveMember class that
stores just the memory buffer and the information that goes into the archive
member header.

http://reviews.llvm.org/D21721

Files:
  include/llvm/Object/ArchiveWriter.h
  lib/LibDriver/LibDriver.cpp
  lib/Object/ArchiveWriter.cpp
  tools/llvm-ar/llvm-ar.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21721.61881.patch
Type: text/x-patch
Size: 20225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160625/337726fd/attachment.bin>


More information about the llvm-commits mailing list