[PATCH] D21685: [ARM] Do not test for CPUs, use SubtargetFeatures (Part 2). NFCI

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 17:44:05 PDT 2016


compnerd accepted this revision.

================
Comment at: lib/Target/ARM/ARM.td:154
@@ +153,3 @@
+// Some processors have a non-pipelined VFP coprocessor.
+def FeatureNonPipelinedVFP : SubtargetFeature<"non-pipelined-vfp",
+                                              "NonPipelinedVFP", "true",
----------------
I believe the proper prefix would be `un` rather than `non`.

================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:3029
@@ +3028,3 @@
+                                                    unsigned NumRegs) {
+  unsigned UOps = 1 + NumRegs; // One for address computation, one for each reg.
+  switch (Opc) {
----------------
The `NumRegs` identifies that you are adding 1 for each of the registers, the comment tail doesn't add much.


http://reviews.llvm.org/D21685





More information about the llvm-commits mailing list