[PATCH] D20335: [AMDGPU] Emit debugger prologue and emit the rest of the debugger fields in the kernel code header

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 13:51:41 PDT 2016


kzhuravl marked 11 inline comments as done.

================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:201-202
@@ -200,1 +200,4 @@
 
+      OutStreamer->emitRawComment(" DebuggerWavefrontPrivateSegmentOffsetSGPR: s" +
+                                  Twine(KernelInfo.DebuggerWavefrontPrivateSegmentOffsetSGPR), false);
+      OutStreamer->emitRawComment(" DebuggerPrivateSegmentBufferSGPR: s" +
----------------
arsenm wrote:
> This willl print the wrong thing if it isn't set. Should it print something else if not valid?
Thanks for catching this one. I have changed it so it only gets printed if amdgpu-debugger-emit-prologue attribute was specified.


http://reviews.llvm.org/D20335





More information about the llvm-commits mailing list