[PATCH] D21681: [ELF] - Implemented support of default/non-default symbols versions

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 05:04:30 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:167
@@ +166,3 @@
+static void setupVersionAttributes(Symbol *Sym, StringRef Name) {
+  size_t VersionBegin = Name.find("@");
+  Sym->VersionedName = VersionBegin != StringRef::npos;
----------------
Before running benchmarks, please change this to `Name.find('@')`. find(char) should be faster than find(StringRef).


http://reviews.llvm.org/D21681





More information about the llvm-commits mailing list