[PATCH] D21481: ELF/AMDGPU: Add support for GOT relocations

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 04:39:03 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Target.cpp:1426
@@ +1425,3 @@
+  switch (Type) {
+  default: error("do not know how to handle relocation");
+  // fall-through
----------------
fatal() is called in relocateOne, so unknown relocations are fatal. Can we also call fatal here?

Also, please run clang-format on this patch.


http://reviews.llvm.org/D21481





More information about the llvm-commits mailing list