[PATCH] D20272: [ELF] - Support of compressed input sections implemented.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

I think this patch is nice and clean. LGTM with a few nits.


================
Comment at: ELF/InputSection.cpp:88
@@ +87,3 @@
+  typedef typename std::conditional<ELFT::Is64Bits, Elf64_Chdr,
+                                    Elf32_Chdr>::type Chdr;
+  const endianness E = ELFT::TargetEndianness;
----------------
Let's name this Elf_Chdr for consistency with other Elf_ types.

================
Comment at: test/ELF/compressed-debug-input.s:6
@@ +5,3 @@
+
+# PACKED:      Section {
+# PACKED:        Index: 2
----------------
Please s/PACK/COMPRESS/g this file.


http://reviews.llvm.org/D20272