[PATCH] D21640: [ELF] - Fix incorrect logic in VersionScriptParser::parseVersion()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 00:31:51 PDT 2016


grimar added inline comments.

================
Comment at: ELF/SymbolListFile.cpp:93
@@ -92,3 +93,1 @@
     parseLocal();
-  else
-    parseVersionSymbols(Version);
----------------
ruiu wrote:
> Why don't you add
> 
>   else if (peek() != "}")
> 
> here?
That was one of the ways and first what I wanted to do. My way looks more clean for my eye, though I am fine with both variants.
I`ll update the patch according to your suggestion then.


http://reviews.llvm.org/D21640





More information about the llvm-commits mailing list