[PATCH] D21645: [CFLAA] Propagate StratifiedAttrs from callee to caller

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 17:47:05 PDT 2016


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for the patch!


================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:644-645
@@ -602,4 +643,4 @@
 
-    GetEdgesVisitor(Analysis, TLI, Graph, ExternalValues, EscapedValues,
-                    InterprocEdges)
+    GetEdgesVisitor(Analysis, TLI, Graph, ReturnedValues, ExternalValues,
+                    EscapedValues, InterprocEdges, InterprocAttrs)
         .visit(Inst);
----------------
Sure -- why doesn't CFLGraphBuilder have a member of type `GetEdgesVisitor`, instead of constructing it in-place here? It doesn't really matter either way, I'm just wondering if there's a reason, since all we're basically doing is loading it up with member variables and calling `visit`.


http://reviews.llvm.org/D21645





More information about the llvm-commits mailing list