[PATCH] D21594: [esan|cfrag] Add counters for struct array accesses

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 14:52:24 PDT 2016


aizatsky requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:174
@@ +173,3 @@
+                           unsigned CounterIdx);
+  unsigned getStructCounterSize(StructType *StructTy) {
+    // We use one counter for each struct field and one additional
----------------
It is not clear to me what you are getting by appending counter to the end rather than adding a fixed field to the struct. Wouldn't the code become simpler?


http://reviews.llvm.org/D21594





More information about the llvm-commits mailing list