[PATCH] D21432: [ARM] Do not test for CPUs, use SubtargetFeatures (Part 1). NFC

[Diana Picus via llvm-commits]

rovka added a comment.

Thanks to everyone for the review.


================
Comment at: lib/Target/ARM/ARMSubtarget.h:221-237
@@ -220,1 +220,19 @@
 
+  /// If true, if conversion may decide to leave some instructions unpredicated.
+  bool IsProfitableToUnpredicate;
+
+  /// If true, VMOV will be favored over VGETLNi32.
+  bool HasSlowVGETLNi32;
+
+  /// If true, VMOV will be favored over VDUP.
+  bool HasSlowVDUP32;
+
+  /// If true, VMOVSR will be favored over VMOVDRR.
+  bool PreferVMOVSR;
+
+  /// If true, ISHST barriers will be used for Release semantics.
+  bool PreferISHST;
+
+  /// If true, VMOVRS, VMOVSR and VMOVS will be converted from VFP to NEON.
+  bool UseNEONForFPMovs;
+
----------------
MatzeB wrote:
> rengolin wrote:
> > rovka wrote:
> > > MatzeB wrote:
> > > > I find member initializers a lot less error prone than having the initializers in a separate method. But we can fix that in another commit.
> > > Ok, I'll try to look into that after I'm done with the subtarget features.
> > Would be good to create a bugzilla about this, so we don't forget.
> IMO switching to member initializers is obvious and trivial enough that it can just be done in an extra commit without review.
Ok, I'm going to commit this now and then hopefully get the member initializers in later today.


http://reviews.llvm.org/D21432