[PATCH] D21621: [codeview] Write LF_UDT_SRC_LINE records (PR28251)

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I think going forward we should try to use more filecheck wildcards so that we don't have to update tests as much when all the typeids shift by one. See virtual-method-kinds.ll for example. That's out of scope here obviously.


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1612
@@ -1597,3 +1611,3 @@
   }
 
   InsertResult.first->second = TI;
----------------
The next thing you should do is toss some of these complete type indices on the GlobalUDTs or LocalUDTs list. MSVC builds S_UDT records for structs, and we don't do that yet.  I guess this should be a separate change, and I just got the two things confused and filed them together.


http://reviews.llvm.org/D21621