[PATCH] D21614: [codeview] Add DISubprogram::ThisAdjustment

[Adrian McCarthy via llvm-commits]

amccarth added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:2466
@@ -2465,3 +2465,3 @@
     case bitc::METADATA_SUBPROGRAM: {
-      if (Record.size() != 18 && Record.size() != 19)
+      if (Record.size() >= 18 && Record.size() <= 20)
         return error("Invalid record");
----------------
It looks like you inverted the sense of the condition while trying to allow for the extra optional field.

I think you want:

    if (Record.size() < 18 || Record.size() > 20)



================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1174
@@ -1174,2 +1173,3 @@
                                                  int ThisAdjustment) {
+  llvm::errs() << "lowerTypeMemberFunction " << ThisAdjustment << '\n';
   // Lower the containing class type.
----------------
Was this for debugging?  Did you mean to leave it in?


http://reviews.llvm.org/D21614