[PATCH] D8688: Update MergedLoadStoreMotion to use MemorySSA

[Geoff Berry via llvm-commits]

gberry added a comment.

I'm still digesting this, but here are a couple more nits I noticed.
I don't want to hold up approval from anyone else though.


================
Comment at: lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:757
@@ -606,1 +756,3 @@
+  PA.preserve<DominatorTreeAnalysis>();
+  PA.preserve<MemorySSAAnalysis>();
   return PA;
----------------
Isn't MemorySSA only preserved if 'UseMemorySSA' is true?

================
Comment at: lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:982
@@ +981,3 @@
+  DomTreeNode *StartNode = DT->getNode(Start->getBlock());
+  std::pair<unsigned, unsigned> StartDFS = {StartNode->getDFSNumIn(),
+                                            StartNode->getDFSNumOut()};
----------------
getDFSNumIn/getDFSNumOut are documented as: These are an internal implementation detail, do not call them.
which seems to conflict with this usage.


http://reviews.llvm.org/D8688