[PATCH] D21536: [CFLAA] Include externally-visible memory aliasing information in function summaries

[Jia Chen via llvm-commits]

grievejia added inline comments.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:760
@@ +759,3 @@
+  DenseMap<StratifiedIndex, InterfaceValue> InterfaceMap;
+
+  // Our intention here is to record all InterfaceValues that share the same
----------------
george.burgess.iv wrote:
> Currently, we unify stratifiedsets both upwards and downwards -- the reason behind this is "that's how I interpreted the paper when I wrote StratifiedSets." :P
> 
> If you want to fix that, then feel free. And yeah, if we do change stratifiedsets to that model, then my proposed approach is broken.
I'll probably kick off another discussion on the topic of unifying strategy: its impact on performance can be very, very big... 


http://reviews.llvm.org/D21536