[PATCH] D21610: [ValueTracking] improve ComputeNumSignBits for vectors

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 11:50:33 PDT 2016


spatel added a comment.

In http://reviews.llvm.org/D21610#464745, @eli.friedman wrote:

> LGTM.
>
> I did a bit of digging about the "Mask <<= Mask.getBitWidth()-TyBits;" thing; it looks like r47654 is at fault.  (The original version of the code used uint64_t instead of APInt.)


Thanks for finding that. I'll delete that line as a separate commit then.


http://reviews.llvm.org/D21610





More information about the llvm-commits mailing list