[PATCH] D21593: test-suite: Remove lemon benchmark

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 11:19:07 PDT 2016


kristof.beyls added a comment.

> > However, it may still make sense to keep this in the test-suite as a correctness test, in which case it should be just listed under "if(NOT TEST_SUITE_BENCHMARKING_ONLY)"?

> 

> 

> Since lemon is a parser, maybe it is okay to totally remove since we have some other benchmarks that represent that class of programs?

> 

> The runtime is sub-second everywhere where I looked, so I think it is fine to keep it in if we think there is any chance that it would detect a miscompile.


Right. I don't have a strong opinion on whether to keep this in non-benchmarking mode only, or to remove the test altogether.
Both options are fine for me.

LGTM.


Repository:
  rL LLVM

http://reviews.llvm.org/D21593





More information about the llvm-commits mailing list