[llvm] r273380 - [LTO] Move UpdateCompilerUsed.h from lib/ to include/

[Rafael Espíndola via llvm-commits]

Could you clean up the include a bit too? In particular

* I don't think you need to include functional in it.
* UpdateCompilerUsed should be updateCompilerUsed.

Cheers,
Rafael


On 22 June 2016 at 00:52, Davide Italiano via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: davide
> Date: Tue Jun 21 23:52:43 2016
> New Revision: 273380
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273380&view=rev
> Log:
> [LTO] Move UpdateCompilerUsed.h from lib/ to include/
>
> I plan to use it in lld soon.
>
> Differential Revision:  http://reviews.llvm.org/D21575
>
> Added:
>     llvm/trunk/include/llvm/LTO/UpdateCompilerUsed.h
>       - copied unchanged from r273191, llvm/trunk/lib/LTO/UpdateCompilerUsed.h
> Removed:
>     llvm/trunk/lib/LTO/UpdateCompilerUsed.h
> Modified:
>     llvm/trunk/lib/LTO/LTOCodeGenerator.cpp
>     llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
>     llvm/trunk/lib/LTO/UpdateCompilerUsed.cpp
>
> Modified: llvm/trunk/lib/LTO/LTOCodeGenerator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOCodeGenerator.cpp?rev=273380&r1=273379&r2=273380&view=diff
> ==============================================================================
> --- llvm/trunk/lib/LTO/LTOCodeGenerator.cpp (original)
> +++ llvm/trunk/lib/LTO/LTOCodeGenerator.cpp Tue Jun 21 23:52:43 2016
> @@ -13,8 +13,8 @@
>  //===----------------------------------------------------------------------===//
>
>  #include "llvm/LTO/LTOCodeGenerator.h"
> +#include "llvm/LTO/UpdateCompilerUsed.h"
>
> -#include "UpdateCompilerUsed.h"
>  #include "llvm/ADT/Statistic.h"
>  #include "llvm/ADT/StringExtras.h"
>  #include "llvm/Analysis/Passes.h"
>
> Modified: llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp?rev=273380&r1=273379&r2=273380&view=diff
> ==============================================================================
> --- llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp (original)
> +++ llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp Tue Jun 21 23:52:43 2016
> @@ -13,12 +13,12 @@
>  //===----------------------------------------------------------------------===//
>
>  #include "llvm/LTO/ThinLTOCodeGenerator.h"
> +#include "llvm/LTO/UpdateCompilerUsed.h"
>
>  #ifdef HAVE_LLVM_REVISION
>  #include "LLVMLTORevision.h"
>  #endif
>
> -#include "UpdateCompilerUsed.h"
>  #include "llvm/ADT/Statistic.h"
>  #include "llvm/ADT/StringExtras.h"
>  #include "llvm/Analysis/ModuleSummaryAnalysis.h"
>
> Modified: llvm/trunk/lib/LTO/UpdateCompilerUsed.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/UpdateCompilerUsed.cpp?rev=273380&r1=273379&r2=273380&view=diff
> ==============================================================================
> --- llvm/trunk/lib/LTO/UpdateCompilerUsed.cpp (original)
> +++ llvm/trunk/lib/LTO/UpdateCompilerUsed.cpp Tue Jun 21 23:52:43 2016
> @@ -11,11 +11,10 @@
>  //
>  //===----------------------------------------------------------------------===//
>
> -#include "UpdateCompilerUsed.h"
> -
>  #include "llvm/Analysis/TargetLibraryInfo.h"
>  #include "llvm/IR/LegacyPassManager.h"
>  #include "llvm/IR/Mangler.h"
> +#include "llvm/LTO/UpdateCompilerUsed.h"
>  #include "llvm/Target/TargetLowering.h"
>  #include "llvm/Target/TargetSubtargetInfo.h"
>  #include "llvm/Transforms/IPO/Internalize.h"
>
> Removed: llvm/trunk/lib/LTO/UpdateCompilerUsed.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/UpdateCompilerUsed.h?rev=273379&view=auto
> ==============================================================================
> --- llvm/trunk/lib/LTO/UpdateCompilerUsed.h (original)
> +++ llvm/trunk/lib/LTO/UpdateCompilerUsed.h (removed)
> @@ -1,34 +0,0 @@
> -//==------ UpdateCompilerUsed.h - LLVM Link Time Optimizer Utility --------===//
> -//
> -//                     The LLVM Compiler Infrastructure
> -//
> -// This file is distributed under the University of Illinois Open Source
> -// License. See LICENSE.TXT for details.
> -//
> -//===----------------------------------------------------------------------===//
> -//
> -// This file declares a helper class to update llvm.compiler_used metadata.
> -//
> -//===----------------------------------------------------------------------===//
> -
> -#ifndef LLVM_LTO_UPDATE_COMPILER_USED_H
> -#define LLVM_LTO_UPDATE_COMPILER_USED_H
> -
> -#include "llvm/ADT/StringSet.h"
> -#include "llvm/IR/GlobalValue.h"
> -
> -#include <functional>
> -
> -namespace llvm {
> -class Module;
> -class TargetMachine;
> -
> -/// Find all globals in \p TheModule that are referenced in
> -/// \p AsmUndefinedRefs, as well as the user-supplied functions definitions that
> -/// are also libcalls, and create or update the magic "llvm.compiler_used"
> -/// global in \p TheModule.
> -void UpdateCompilerUsed(Module &TheModule, const TargetMachine &TM,
> -                        const StringSet<> &AsmUndefinedRefs);
> -}
> -
> -#endif // LLVM_LTO_LTOINTERNALIZE_H
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits