[PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

[Hubert Tong via llvm-commits]

hubert.reinterpretcast added inline comments.

================
Comment at: include/llvm/Support/TrailingObjects.h:353
@@ +352,3 @@
+  ///
+  /// \code{.cpp}
+  ///
----------------
aaron.ballman wrote:
> That's novel (we use it in two other places from what I can tell).
This is a documented Doxygen command:
https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdcode

The presence of the file extension in the existing use is mostly harmless to older versions of Doxygen:
http://www.llvm.org/docs/doxygen/html/classllvm_1_1TypeBuilder.html#details

Since this is present in a .h header, I am not sure we will get C++ (as opposed to C) syntax coloring reliably otherwise.


================
Comment at: include/llvm/Support/TrailingObjects.h:378
@@ +377,3 @@
+
+    BaseTy *get() { return p; }
+
----------------
aaron.ballman wrote:
> Should we have a const overload for this?
I can add one. It will return a pointer-to-const since the semantics of this class is that it owns the memory.



http://reviews.llvm.org/D19770