[PATCH] D21543: [polly] Respect LLVM_INSTALL_TOOLCHAIN_ONLY

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 17:07:23 PDT 2016


grosser added a comment.

In http://reviews.llvm.org/D21543#463824, @Eugene.Zelenko wrote:

> In http://reviews.llvm.org/D21543#463822, @grosser wrote:
>
> > In http://reviews.llvm.org/D21543#463483, @Eugene.Zelenko wrote:
> >
> > > I'll commit only CMake files changes.
> >
> >
> > Does this mean you do not plan to drop the autoconf directory any more? What was the reason you decided against it? From my perspective you can drop it without further review. The only thing I asked for to use different commits. I hope this did not discourage you.
>
>
> Problem that removing autoconf directory require to commit ., and this conflicts with uncommitted http://reviews.llvm.org/D21488.


OK. So this seems to mostly be a shortcoming of the version control system. As the change is trivial and committing it seems to cause complications on your side, I just committed this myself in r273338. Thanks for reporting the leftover directory.

Best,
Tobias

PS: It seems you are still using svn. You might want consider the use of 'git', which makes working with patches a lot easier. This comes often handy when addressing review comments and working with more than one patch at a time.


Repository:
  rL LLVM

http://reviews.llvm.org/D21543





More information about the llvm-commits mailing list