[lld] r273337 - Simplify writeThunk. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 16:53:08 PDT 2016


Author: ruiu
Date: Tue Jun 21 18:53:08 2016
New Revision: 273337

URL: http://llvm.org/viewvc/llvm-project?rev=273337&view=rev
Log:
Simplify writeThunk. NFC.

Previously, `Buf + 4` was written twice.

Modified:
    lld/trunk/ELF/Target.cpp

Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=273337&r1=273336&r2=273337&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Tue Jun 21 18:53:08 2016
@@ -1839,12 +1839,11 @@ void MipsTargetInfo<ELFT>::writeThunk(ui
   // Write MIPS LA25 thunk code to call PIC function from the non-PIC one.
   // See MipsTargetInfo::writeThunk for details.
   const endianness E = ELFT::TargetEndianness;
-  write32<E>(Buf, 0x3c190000);      // lui   $25, %hi(func)
-  write32<E>(Buf + 4, 0x08000000);  // j     func
-  write32<E>(Buf + 8, 0x27390000);  // addiu $25, $25, %lo(func)
-  write32<E>(Buf + 12, 0x00000000); // nop
+  write32<E>(Buf, 0x3c190000);                // lui   $25, %hi(func)
+  write32<E>(Buf + 4, 0x08000000 | (S >> 2)); // j     func
+  write32<E>(Buf + 8, 0x27390000);            // addiu $25, $25, %lo(func)
+  write32<E>(Buf + 12, 0x00000000);           // nop
   writeMipsHi16<E>(Buf, S);
-  write32<E>(Buf + 4, 0x08000000 | (S >> 2));
   writeMipsLo16<E>(Buf + 8, S);
 }
 




More information about the llvm-commits mailing list