[PATCH] D20992: [CMake] Add LLVM runtimes directory

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 14:37:05 PDT 2016


beanz updated this revision to Diff 61451.
beanz added a comment.

I kinda went a bit off into the woods after the llvm-dev thread, and I think I came back with something either interesting or insane... you decide.

This patch changed a few things about how I'm handling the runtimes subdirectory. First, it handles the compiler-rt builtin library dependency by building the builtins first as their own external project call. Second, it glumps all the other runtime libraries (including compiler-rt's sanitizers) into a single external project by using the runtimes/CMakeLists.txt file as the top-level CMake.

This is interesting for a few reasons. The biggest is a potential for reduced CMake-overhead when building runtime libraries. Additionally it will allow cross-project dependencies to be  more easily modeled in CMake because the runtime libraries will be able to be aware of the targets coming from other runtime projects.

Thoughts?


http://reviews.llvm.org/D20992

Files:
  CMakeLists.txt
  cmake/modules/LLVMExternalProjectUtils.cmake
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20992.61451.patch
Type: text/x-patch
Size: 6364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160621/0da2297c/attachment.bin>


More information about the llvm-commits mailing list