[PATCH] D11621: AMDGPU/SI: Mark SMRD instructions as rematerializable

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 13:36:58 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:79-81
@@ -78,2 +78,5 @@
                                                     AliasAnalysis *AA) const {
+  if (isSMRD(MI->getOpcode()))
+    return true;
+
   // TODO: The generic check fails for VALU instructions that should be
----------------
We probably don't need this. It looks like if isReallyTriviallyReMaterializable fails, it will still check isReallyTriviallyReMaterializableGeneric which checks the AA for you


http://reviews.llvm.org/D11621





More information about the llvm-commits mailing list