[PATCH] D21552: [ELF] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 11:17:39 PDT 2016


davide added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:571
@@ +570,3 @@
+    DictScope Dep(W, "Dependencies");
+    const uint8_t *PAux = P + VD->vd_aux + VD->getAux()->vda_next;
+    for (unsigned J = 0; J < (unsigned)VD->vd_cnt - 1; ++J) {
----------------
How many dependencies can you have?
IIRC you can have only one immediate parent/dependency so it's probably easier/more reasonable to only print that, no?
If you can have multiple dependencies, instead, can you please add a test exercising that behaviour?


http://reviews.llvm.org/D21552





More information about the llvm-commits mailing list