[PATCH] D21556: [ELF] - Implemented version script hierarchies.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 11:15:43 PDT 2016


davide added a subscriber: davide.

================
Comment at: ELF/OutputSections.cpp:1510
@@ +1509,3 @@
+
+  Verdaux[-1].vda_next = sizeof(Elf_Verdaux);
+  Verdaux->vda_name = getVersionNameStrTabOffset(DependencyName);
----------------
It could be just me, but I'd rather prefer this -1 to be assigned to a variable or adding a comment to explain what this code does.


http://reviews.llvm.org/D21556





More information about the llvm-commits mailing list