[PATCH] D21372: [ARM] Lower (select_cc k k (select_cc ~k ~k x)) into (SSAT l_k x)

[Pablo Barrio via llvm-commits]

pbarrio updated this revision to Diff 61386.
pbarrio added a comment.

Addressed concerns about refactoring, comments and testing

Renato, thank you for the review. I have refactored the logic into a separate
function and used early returns as suggested. I have also modified the comments
so that they are clearer.

I have extensively cleaned up the tests and added some more. This time, the naming
is much better because it's done by me :)  The previous tests were directly taken
from compiling a C file with use cases into IR, hence the cryptic names. Some of the
tests were also redundant because LLVM normalizes some constructs, so different C
code was transformed into the same IR. I have removed these - lesson learned.

I hope you find this version more readable, but let me know if you find room for
improvement. Thanks again!


http://reviews.llvm.org/D21372

Files:
  include/llvm/Target/TargetSelectionDAG.td
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.h
  lib/Target/ARM/ARMInstrInfo.td
  lib/Target/ARM/ARMInstrThumb2.td
  test/CodeGen/ARM/ssat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21372.61386.patch
Type: text/x-patch
Size: 16157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160621/98eb1573/attachment.bin>