[PATCH] D21526: [codeview] Improved array type support (multi dimension array)

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 12:57:23 PDT 2016


majnemer added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:881
@@ +880,3 @@
+
+    // FIXME: this is a WA solution until solving dynamic array boundary.
+    if (Count == -1) {
----------------
rnk wrote:
> This comment needs work. It's worth mentioning that a count of -1 means that this is a VLA, and that it is not currently representable in CodeView. Actually, why not just let it go through as ~0U?
Can't we use LF_DIMVARLU for VLAs?


http://reviews.llvm.org/D21526





More information about the llvm-commits mailing list