[PATCH] D21308: AArch64: Fix end iterator dereference

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 11:21:42 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AArch64/AArch64BranchRelaxation.cpp:472
@@ +471,3 @@
+
+    MachineInstr &MI = *J;
+    if (isConditionalBranch(MI.getOpcode()) &&
----------------
john.brawn wrote:
> Making a reference only to then take the address of it when calling fixupConditionalBranch seems a little odd. I'd just stick with a pointer.
I was trying to avoid &*I which is gross


http://reviews.llvm.org/D21308





More information about the llvm-commits mailing list