[PATCH] D21513: [CFLAA] Try to be less conservative on more functions

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 09:27:45 PDT 2016


sanjoy requested changes to this revision.
sanjoy added a reviewer: sanjoy.
This revision now requires changes to proceed.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:371
@@ -370,3 +370,3 @@
   static bool isFunctionExternal(Function *Fn) {
-    return Fn->isDeclaration() || !Fn->hasLocalLinkage();
+    return Fn->isDeclaration() || !Fn->hasExactDefinition();
   }
----------------
`hasExactDefinition` checks for `isDeclaration`.  You should just be able to replace `isFunctionExternal(F)` with `F->hasExactDefinition()`.


http://reviews.llvm.org/D21513





More information about the llvm-commits mailing list