[PATCH] D21400: AMDGPU: Emit R_AMDGPU_ABS32_{HI,LO} for scratch buffer relocations

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 07:25:13 PDT 2016


Cool, LGTM.

On 20 June 2016 at 09:27, Tom Stellard <thomas.stellard at amd.com> wrote:
> tstellarAMD added a comment.
>
> In http://reviews.llvm.org/D21400#461541, @rafael wrote:
>
>> Lgtm, but I have a question:
>>
>> Will SCRATCH_RSRC_DWORD also need special  treatment in the linker? If so
>>  we should have special relocations for it to avoid using names in the
>>  linker. This is similar to how the got position is accessed: magical name
>>  for the assembler, different relocation for the linker.
>
>
> This won't need any special handling in the linker.  This is only used by our legacy path which does not use lld at all.
>
>
> http://reviews.llvm.org/D21400
>
>
>


More information about the llvm-commits mailing list