[PATCH] D21018: [ELF] - Basic versioned symbols support implemented.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 19 23:10:23 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D21018#461946, @ruiu wrote:


What a good morning :) Thanks for review, I'll commit in a few hours then.

Comment at: ELF/SymbolTable.cpp:535
@@ +534,3 @@
+      if (SymbolBody *B = find(Name))
+        B->symbol()->VersionId = I;
+    ++I;
ruiu wrote:
> I'm wondering if this could be `I++`?
No, because each Version can have a list of globals. And all of them should receive the same VersionId.


More information about the llvm-commits mailing list