[PATCH] D20297: AMDGPU/SI: Add implicitarg.ptr intrinsic.
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 17 20:20:20 PDT 2016
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D20297#449024, @jvesely wrote:
> In http://reviews.llvm.org/D20297#444575, @arsenm wrote:
> > In http://reviews.llvm.org/D20297#442193, @tstellarAMD wrote:
> > > In http://reviews.llvm.org/D20297#441156, @arsenm wrote:
> > >
> > > > Why not the offset from the base pointer intrinsic rather than an intrinsic to the offset?
> > >
> > >
> > > Because if the implict args are stored after the explict kernel args, then the offset from kernarg.base.ptr to the start of implicit args is not known until compile time.
> > Why is this an issue? This won't be known anyway
> just to be sure I understand correctly. your suggestion is to have "implicitarg.offset" so the libclc(or any other user) then uses "_builtin_kernarg_segment_ptr() + _builtin_implict_arg_offset()" to read the implicit arguments?
I have no preference either way on this. Since this patch has been outstanding for a while, I say just commit it. We can always add _builtin_implict_arg_offset() later if we decide it is a better solution.
More information about the llvm-commits