[PATCH] D21465: [llc+llvm-mc] Replace the hidden -target-abi option with a -mabi thats visible in --help.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 10:00:25 PDT 2016

On 17 June 2016 at 11:22, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:
>> -----Original Message-----
>> From: Rafael EspĂ­ndola [mailto:rafael.espindola at gmail.com]
>> Sent: 17 June 2016 15:16
>> To: reviews+D21465+public+92eb7897bc2cfded at reviews.llvm.org; Daniel
>> Sanders
>> Cc: llvm-commits; filcab+llvm.phabricator at gmail.com
>> Subject: Re: [PATCH] D21465: [llc+llvm-mc] Replace the hidden -target-abi
>> option with a -mabi thats visible in --help.
>> If it will be in the triple, why do you need the -mabi command line option?
> If LLVM's backend tests always used -triple/-mtriple to specify a complete triple then I
> wouldn't need it but a lot of tests specify the architecture using -march and take on
> aspects of the host triple*. The -mabi option will apply the necessary (OS and
> environment dependent) transformation to the triple to achieve the desired ABI.

OK, we should change that if the entire information is to be available
in the triple.

So, moving the option out of MCTargetOptionsCommandFlags.h and into
llvm-mc.cpp is a good thing, but why do you need to rename it?


More information about the llvm-commits mailing list