[PATCH] D21434: [CMake] Add LLVM_BUILD_32_BITS to LLVMConfig.cmake
John Brawn via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 17 07:01:33 PDT 2016
john.brawn added a comment.
In http://reviews.llvm.org/D21434#460551, @chapuni wrote:
> I don't like this idea that exposes LLVM_BUILD_32_BITS. Didn't you inspect LLVM_C*_FLAGS?
LLVM_C*_FLAGS don't exist in LLVMConfig.cmake. I see LLVM_BUILD_32_BITS as similar in a way to LLVM_ENABLE_EH and LLVM_ENABLE_RTTI - it's something where out-of-tree plugins need to be aware of how LLVM was built otherwise LLVM will give an error when trying to load the plugin, so it needs to be exposed somehow.
More information about the llvm-commits