[PATCH] D21297: [ELF][MIPS] Support GOT entries for non-preemptible symbols with different addends

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 22:22:41 PDT 2016


atanasyan updated this revision to Diff 61066.
atanasyan added a comment.

- Replace `llvm_unreachable` by assert.
- Fix comment formatting.
- Use lambda for adding entries to the `MipsLocal` and `MipsGlobal` containers. For my taste now `GotSection<ELFT>::addMipsEntry` looks a bit more clear.


Repository:
  rL LLVM

http://reviews.llvm.org/D21297

Files:
  ELF/InputSection.cpp
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/Target.cpp
  test/ELF/mips-64-disp.s
  test/ELF/mips-64-got.s
  test/ELF/mips-dynamic.s
  test/ELF/mips-got16.s
  test/ELF/mips-plt-copy.s
  test/ELF/mips-sto-plt.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21297.61066.patch
Type: text/x-patch
Size: 30549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160617/ea9c8079/attachment.bin>


More information about the llvm-commits mailing list