[PATCH] D21442: [CodeView] Implement support for enums

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 17:19:50 PDT 2016


aaboud added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1095
@@ +1094,3 @@
+  else
+    std::tie(FTI, FieldCount) = lowerRecordFieldList(Ty);
+
----------------
Can you explain why we are lowering "Record Field List" instead of "Enumeration Field List"?
There is nothing in common between enum and class, is there?

I suggest to create a new function called lowerEnumerationFieldList(). 


Repository:
  rL LLVM

http://reviews.llvm.org/D21442





More information about the llvm-commits mailing list