[PATCH] D21205: Pass AssumptionCacheTracker from SampleProfileLoader to Inliner

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 15:45:35 PDT 2016

eraman added a subscriber: eraman.
eraman added a comment.

In http://reviews.llvm.org/D21205#458903, @danielcdh wrote:

> This test is just testing if SampleLoader will crash under certain conditions. You are right, the crash will only happen when 3 of these conditions satisfy. It's more like a robustness test, so FileCheck may not be an option here.

IT looks like this use of IFI is at the InlineFunction method where a phi node is inserted when the callee has multiple exits and the result of the call is used. I think the test case can be simplified without needing to have any debug information. Alternatively, there are other places where IFI is used without any guards - for example when there is a pointer parameter with a specified  alignment.


More information about the llvm-commits mailing list