[llvm] r272505 - [PM] Port ReversePostOrderFunctionAttrs to the new PM

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 14:49:07 PDT 2016


On Thu, Jun 16, 2016 at 2:44 PM, Davide Italiano <dccitaliano at gmail.com>
wrote:

> On Thu, Jun 16, 2016 at 2:42 PM, Xinliang David Li <xinliangli at gmail.com>
> wrote:
> > Davide, as Danny noticed, I think the main troublesome patch is r272595.
> > There is no need to eliminate that class and statiize all the methods.
> > Instead, what is needed is to move legacy pass specific members out of
> class
> > MergedLoadStoreMotion and keep the original class as the 'transformation
> > class' that can be shared.
> >
> > Can you revert that change and do the above suggested refactoring -- that
> > will only take a few lines, I think.
> >
>
> Already reverted, working on a fix now. Sorry for the trouble.
>


no problem -- thanks for the quick action :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160616/53ddf45c/attachment.html>


More information about the llvm-commits mailing list