[llvm] r272955 - [EarlyCSE] Minor cosmetic NFC changes

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 14:00:57 PDT 2016


Author: sanjoy
Date: Thu Jun 16 16:00:57 2016
New Revision: 272955

URL: http://llvm.org/viewvc/llvm-project?rev=272955&view=rev
Log:
[EarlyCSE] Minor cosmetic NFC changes

 - Avoid implicit conversion from pointer to bool
 - Add a comment when passing in a boolean value

Modified:
    llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp?rev=272955&r1=272954&r2=272955&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp Thu Jun 16 16:00:57 2016
@@ -434,7 +434,7 @@ private:
 
     bool isInvariantLoad() const {
       if (auto *LI = dyn_cast<LoadInst>(Inst))
-        return LI->getMetadata(LLVMContext::MD_invariant_load);
+        return LI->getMetadata(LLVMContext::MD_invariant_load) != nullptr;
       return false;
     }
 
@@ -763,7 +763,7 @@ bool EarlyCSE::processNode(DomTreeNode *
         AvailableLoads.insert(
             MemInst.getPointerOperand(),
             LoadValue(Inst, CurrentGeneration, MemInst.getMatchingId(),
-                      MemInst.isAtomic(), false));
+                      MemInst.isAtomic(), /*IsInvariant=*/false));
 
         // Remember that this was the last unordered store we saw for DSE. We
         // don't yet handle DSE on ordered or volatile stores since we don't




More information about the llvm-commits mailing list