[PATCH] D21011: [codeview] Add complex record type translation

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 13:21:52 PDT 2016

rnk added inline comments.

Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1050-1051
@@ +1049,4 @@
+  // TODO: We should use DW_AT_calling_convention to determine what CC this
+  // procedure record should have.
+  // TODO: Need to use the correct values for:
The TODO is done, you can delete the comment.

Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1132
@@ +1131,3 @@
+struct llvm::ClassInfo {
+  struct MemberInfo {
majnemer wrote:
> Does this need to be in the LLVM namespace?  Why not stick it in an anonymous namespace?
It does, it's forward declared and used as an incomplete type in the header.


More information about the llvm-commits mailing list