[PATCH] D21297: [ELF][MIPS] Support GOT entries for non-preemptible symbols with different addends

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 13:10:13 PDT 2016

atanasyan marked 2 inline comments as done.

Comment at: ELF/OutputSections.h:159
@@ +158,3 @@
+  // to handle them uniformly.
+  typedef std::pair<const SymbolBody*, uintX_t> MipsGotSAPair;
+  llvm::DenseMap<MipsGotSAPair, size_t> MipsGotMap;
ruiu wrote:
> Instead of std::pair, can you define a struct, so that instead of first/second, we can use meaningful names?
> Instead of std::pair, can you define a struct

In that case I have to define some additional stuff like `getEmptyKey`, `isEqual`, ... to be able to use this struct in the DenseMap. For my taste it makes the code overcomplicated.



More information about the llvm-commits mailing list