[PATCH] D21410: [pdb] Change type visitor pattern to use dynamic polymorphism

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 11:17:57 PDT 2016

rnk added a comment.

In http://reviews.llvm.org/D21410#460027, @zturner wrote:

> One added advantage of this approach is that, while rebasing, I actually caught a couple of bugs in Rui's patch that would not have been possible to catch at compile time otherwise.  Mainly there were previously separate visitation functions for class, struct, and interface, but these are all implemented by a single record type, and thus have only a single visitation function.  This was caught because when I added the `override` keyword to them, the compiler error'ed saying that there was no suitable function to override.

Acking on the mailing list that I buy this reasoning, lgtm



More information about the llvm-commits mailing list