[PATCH] D21439: [ELF] - Handle every global as unversioned export in versioned script.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 11:05:30 PDT 2016

ruiu added a comment.

LGTM with nits.

Comment at: ELF/SymbolListFile.cpp:102
@@ +101,3 @@
+void VersionScriptParser::run() {
+  StringRef Err = "anonymous version definition is used in "
+                  "combination with other version definitions";
I'd call it Msg.

Acutally, my preference is to use goto to jump to the end of the function and call setError("anonymous version def..."), but probably there are many people who don't like it, so I'm okay with this.

Comment at: ELF/SymbolListFile.cpp:113
@@ +112,3 @@
+    if (next() == "{")
+      setError(Err);
+    else
Let's return after setError(). (And remove `else`.)


More information about the llvm-commits mailing list