[PATCH] D21011: [codeview] Add complex record type translation

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 10:53:48 PDT 2016

aaboud marked an inline comment as done.
aaboud added a comment.

Thanks Reid for the comments, I will upload a new version with a LIT tests and some fixes.

Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1202
@@ +1201,3 @@
+    if (auto *SP = dyn_cast<DISubprogram>(Element)) {
+      Info.Methods[SP->getRawName()].push_back({ SP, true });
+    } else if (auto *DDTy = dyn_cast<DIDerivedType>(Element)) {
rnk wrote:
> Should we claim that all methods are introduced virtual methods, or just the virtual ones?
Introduce is only for virtual methods, however the "Methods" container holds all methods of the class (virtual and non-virtual).
I am using the same container to be able to output the methods in the right order, though I am not sure if the order is important!

See "translateMethodKindFlags" at line 1091, where it consider the "Introduced" variable only for virtual functions.


More information about the llvm-commits mailing list