[PATCH] D21408: [ARM] MRRC2 shouldn't allow predicates

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 10:14:24 PDT 2016

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D21408#459903, @rs wrote:

> It definitely broke upstream buildbots I got the emails so reverted the patches straight away. It was due to a silly mistake of not building with asserts enabled.

Right, so probably never hit our bots. I didn't see your revert, sorry.

> Basically it was complaining that the MRRC2 instruction that was being built in ARMISelDAGToDAG.cpp had more operands than were allowed by the tablegen description for the instruction


> (...)

>  As you can see the instruction doesn't allow you to specify any predicates.


> Yes AL is allowed as a predicate to MRRC2 in assembly but whether it's specified or not the top 4 bits will always be 1111 not 1110 which is the encoding for AL. I've updated my patch comment as the previous comment is wrong.

Ok, it makes sense now, thanks!

Please, create a bug for addressing the FIXME, feel free to copy me.

LGTM, thanks!


More information about the llvm-commits mailing list