[llvm] r272595 - [PM/MergeLoadStoreMotion] Convert the logic to static functions.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 10:09:57 PDT 2016

On Thu, Jun 16, 2016 at 9:20 AM, Daniel Berlin <dberlin at dberlin.org> wrote:
> (and note, you didn't explain, anywhere, why any of these changes are
> necessary for the new PM, they look, at a glance, like completely orthogonal
> refactorings)
> On Thu, Jun 16, 2016 at 9:07 AM, Daniel Berlin <dberlin at dberlin.org> wrote:
>> I don't remember seeing this for review, and you've basically taken a very
>> well organized class and completely destroyed its organizational structure
>> by creating a mix of class member functions and random non-class static
>> functions.
>> I don't see this as an improvement, even for the new PM.
>> I also don't think we should try to take every single pass that is a class
>> in LLVM and necessarily turn it into a bunch of static functions that pass
>> around what was previously class state.
>> I'm going to ask you to revert and actually post a patch for review so
>> this can be actually discussed.

I'm reverting this now. Please let me know if there are other passes
converted by me which you want to see reverted and I'll do it.



"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare

More information about the llvm-commits mailing list