[PATCH] D21431: [arm+x86] Make GNU variants behave like GNU w.r.t combining sin+cos into sincos.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 09:31:14 PDT 2016

dsanders added a comment.

In http://reviews.llvm.org/D21431#459909, @t.p.northover wrote:

> I think it's just an omission to. `sincos` is definitely in my local copy of libm.so. I say go for it! (And thanks for the work).
> Tim.


In http://reviews.llvm.org/D21431#459913, @t.p.northover wrote:

> Actually, it looks like it's in the androideabi too (since 2.3), so it might be a good idea to add that.
> Tim.

Is this combine beneficial for android at the moment? According to https://android.googlesource.com/platform/bionic/+/master/libm/sincos.c, android's sincos uses -O0 and just forwards the call to sin and cos. It looks like you'd be getting two calls for the price of three.


More information about the llvm-commits mailing list