[PATCH] D21018: [ELF] - Basic versioned symbols support implemented.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 06:44:49 PDT 2016

Also, I think this patch can be split, no?

We should be able to first update just the parser, so that we parse

foo { ...};
bar {...};

but handle it as putting every global symbol as an unversioned export.


On 16 June 2016 at 09:38, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 16 June 2016 at 09:25, George Rimar <grimar at accesssoftek.com> wrote:
>>>rafael added inline comments.
>>>Comment at: ELF/SymbolListFile.cpp:80
>>>@@ +79,3 @@
>>>+  void parseUnversionedScript();
>>>+  void parseVersionedScript();
>>>Do we really need to duplicate the parsing? We should be able to have a single parser and take different actions based on the name, no?
>> That was done in that way in initial version of the patch (please see diff 1).
>> And Rui requested to separate this during review.
> I think the request was just for the semantic handling, no?
> Cheers,
> Rafael

More information about the llvm-commits mailing list